[ATrpms-users] Any chance in including the following patch in the video4linux rpms?

Axel Thimm Axel.Thimm at ATrpms.net
Mon Dec 24 16:53:37 CET 2007


On Mon, Dec 24, 2007 at 10:40:29AM -0500, Jeffrey J. Kosowsky wrote:
> Axel,
> As you probably know, ever since kernel 2.6.22, the module lirc_gpio
> has been broken, leaving people mostly with the option of using the
> devinput driver.
> 
> I have a Winfast 2000XP Deluxe analog TV card with IR remote which
> unfortunately is "broken" in the standard bttv-input.c source code.
> I built a simple patch that works based on some googling around the
> input and have submitted it back to Fedora bugzilla but they seem to
> be taking their time in incorporating it.
> 
> The bugzilla reference is:
> https://bugzilla.redhat.com/show_bug.cgi?id=369921
> 
> Any chance of including this patch in your video4linux kmdl?

Sure, but at this time (Xmas) I'm a bit short of spare time, so in
order to not forget this, could you file it up as a bugzilla? I'll do
an updating of v4l to the latest code after Xmas and include this
patch (if it isn't already in the code by then).

Thansk!

> Note that the patch (below) itself is pretty simple and harmless --
> even further so since both one-liner changes explicitly only effect
> "BTTV_BOARD_WINFAST_2000" which is broken anyway without it...
> 
> The patch is simply:
> 
> --- bttv-input.c.orig	2007-07-08 19:32:17.000000000 -0400
> +++ bttv-input.c		2007-11-07 01:15:33.000000000 -0500
> @@ -70,6 +70,7 @@
>        (ir->mask_keyup    &&  (0 == (gpio & ir->mask_keyup)))) {
>  	   					  ir_input_keydown(ir->dev,&ir->ir,data,data);
>  						  } else {
> +						  	if (btv->c.type == BTTV_BOARD_WINFAST2000)
> ir_input_keydown(ir->dev,&ir->ir,data,data);
> 				ir_input_nokey(ir->dev,&ir->ir);
>  				}
>  
> @@ -242,7 +243,7 @@
>  
> 		case BTTV_BOARD_WINFAST2000:
>  			 ir_codes         = ir_codes_winfast;
> -			 				  ir->mask_keycode = 0x1f8;
> +							  				   ir->mask_keycode =
>  			 0x8f8;
> 				break;
>  				case BTTV_BOARD_MAGICTVIEW061:
>  				case BTTV_BOARD_MAGICTVIEW063:
> 
> _______________________________________________
> atrpms-users mailing list
> atrpms-users at atrpms.net
> http://lists.atrpms.net/mailman/listinfo/atrpms-users

-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.atrpms.net/pipermail/atrpms-users/attachments/20071224/8290363f/attachment.bin 


More information about the atrpms-users mailing list