[ATrpms-devel] sk98lin FC5

[Paulo Cavalcanti]

I think the latest patch was not applied,
for some reason.

Before it was

#if USE_SYNC_TX_QUEUE

which produced the error you got.

I changed it to

#ifdef USE_SYNC_TX_QUEUE

in the patch, which should skip the code

I uploaded the .src.rpm yesterday.
Please, take a look at it. I think I changed

I have no errors, as you can see below,
and I have only the kernel-smp-devel installed.


/Paulo Roma.

-------------------------------------------------------------------------
+ make -C /usr/src/kernels/2.6.17-1.2157_FC5smp-i686SUBDIRS=/home/roma/redhat/BUILD/DriverInstall/2.6
CONFIG_SK98LIN=m
make: Entering directory `/usr/src/kernels/2.6.17-1.2157_FC5-smp-i686'
  LD      /home/roma/redhat/BUILD/DriverInstall/2.6/built-in.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skge.o
/home/roma/redhat/BUILD/DriverInstall/2.6/skge.c:301: warning:
initialization from incompatible pointer type
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/sky2.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skethtool.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/sky2le.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skdim.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skaddr.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skgehwt.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skgeinit.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skgepnmi.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skgesirq.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/sktwsi.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/sklm80.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skqueue.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skrlmt.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/sktimer.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skvpd.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skxmac2.o
/home/roma/redhat/BUILD/DriverInstall/2.6/skxmac2.c: In function
'SkGmClearRst':
/home/roma/redhat/BUILD/DriverInstall/2.6/skxmac2.c:1144: warning: unused
variable 'Word'
/home/roma/redhat/BUILD/DriverInstall/2.6/skxmac2.c:1143: warning: unused
variable 'PhyId1'
/home/roma/redhat/BUILD/DriverInstall/2.6/skxmac2.c:1142: warning: unused
variable 'PhyId0'
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skproc.o
  CC [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/skcsum.o
  LD [M]  /home/roma/redhat/BUILD/DriverInstall/2.6/sk98lin.o
  Building modules, stage 2.
------------------------------------------------------------------------------------


On 7/23/06, Axel Thimm <Axel.Thimm at atrpms.net> wrote:
>
> Hi,
>
> On Sun, Jul 23, 2006 at 10:05:05AM -0300, Paulo Cavalcanti wrote:
> > Hi, Axel
> >
> > I built it for the latest FC5 kernel:
> >
> > Linux version 2.6.17-1.2157_FC5smp
> >
> > It seems that "tso_size" disappeared in this kernel.
> > I think it is "gso_size" now.
>
> My 2.6.17-1.2157_FC5 builds fail and claim the opposite :)
>
>   CC [M]  /builddir/DriverInstall/2.6/skge.o
> /builddir/DriverInstall/2.6/skge.c:301: warning: initialization from
> incompatible pointer type
>   CC [M]  /builddir/DriverInstall/2.6/sky2.o
> /builddir/DriverInstall/2.6/sky2.c:341:5: warning: "USE_SYNC_TX_QUEUE" is
> not defined
> /builddir/DriverInstall/2.6/sky2.c:906:5: warning: "USE_SYNC_TX_QUEUE" is
> not defined
> /builddir/DriverInstall/2.6/sky2.c: In function 'GiveTxBufferToHw':
> /builddir/DriverInstall/2.6/sky2.c:994: error: 'struct skb_shared_info'
> has no member named 'tso_size'
> /builddir/DriverInstall/2.6/sky2.c:2315:5: warning: "USE_SYNC_TX_QUEUE" is
> not defined
> make[1]: *** [/builddir/DriverInstall/2.6/sky2.o] Error 1
>
> This is against 2.6.17-1.2157_FC5 on i686.
>
> > But for the previous kernels,
> > it has to be used "tso_size", indeed. They were working anyway.
> >
> > I do not know how to automatize this in the spec file.
> >
> > /Paulo Roma.
> >
> >
> > On 7/23/06, Axel Thimm <Axel.Thimm at atrpms.net> wrote:
> > >
> > >On Sat, Jul 22, 2006 at 07:59:48PM -0300, Paulo Cavalcanti wrote:
> > >>  #ifdef NETIF_F_TSO
> > >> -                       Mss = skb_shinfo(pSkPacket->pMBuf)->tso_size;
> > >> +                       Mss = skb_shinfo(pSkPacket->pMBuf)->gso_size;
> > >>                         if (Mss) {
> > >
> > >This breaks on almost every kernel. What kernel did you build this
> > >against?
>
> > _______________________________________________
> > atrpms-devel mailing list
> > atrpms-devel at atrpms.net
> > http://lists.atrpms.net/mailman/listinfo/atrpms-devel
>
> --
> Axel.Thimm at ATrpms.net
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.atrpms.net/pipermail/atrpms-devel/attachments/20060723/eed9fcdc/attachment-0001.html