[ATrpms-devel] sk98lin FC5

[Axel Thimm]

Hi,

On Sun, Jul 23, 2006 at 10:05:05AM -0300, Paulo Cavalcanti wrote:
> Hi, Axel
> 
> I built it for the latest FC5 kernel:
> 
> Linux version 2.6.17-1.2157_FC5smp
> 
> It seems that "tso_size" disappeared in this kernel.
> I think it is "gso_size" now.

My 2.6.17-1.2157_FC5 builds fail and claim the opposite :)

  CC [M]  /builddir/DriverInstall/2.6/skge.o
/builddir/DriverInstall/2.6/skge.c:301: warning: initialization from incompatible pointer type
  CC [M]  /builddir/DriverInstall/2.6/sky2.o
/builddir/DriverInstall/2.6/sky2.c:341:5: warning: "USE_SYNC_TX_QUEUE" is not defined
/builddir/DriverInstall/2.6/sky2.c:906:5: warning: "USE_SYNC_TX_QUEUE" is not defined
/builddir/DriverInstall/2.6/sky2.c: In function 'GiveTxBufferToHw':
/builddir/DriverInstall/2.6/sky2.c:994: error: 'struct skb_shared_info' has no member named 'tso_size'
/builddir/DriverInstall/2.6/sky2.c:2315:5: warning: "USE_SYNC_TX_QUEUE" is not defined
make[1]: *** [/builddir/DriverInstall/2.6/sky2.o] Error 1

This is against 2.6.17-1.2157_FC5 on i686.

> But for the previous kernels,
> it has to be used "tso_size", indeed. They were working anyway.
> 
> I do not know how to automatize this in the spec file.
> 
> /Paulo Roma.
> 
> 
> On 7/23/06, Axel Thimm <Axel.Thimm at atrpms.net> wrote:
> >
> >On Sat, Jul 22, 2006 at 07:59:48PM -0300, Paulo Cavalcanti wrote:
> >>  #ifdef NETIF_F_TSO
> >> -                       Mss = skb_shinfo(pSkPacket->pMBuf)->tso_size;
> >> +                       Mss = skb_shinfo(pSkPacket->pMBuf)->gso_size;
> >>                         if (Mss) {
> >
> >This breaks on almost every kernel. What kernel did you build this
> >against?

> _______________________________________________
> atrpms-devel mailing list
> atrpms-devel at atrpms.net
> http://lists.atrpms.net/mailman/listinfo/atrpms-devel

-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.atrpms.net/pipermail/atrpms-devel/attachments/20060723/2fece685/attachment.bin